Repository navigation
Conversation
The App panel at the bottom of the sidebar listed eight entries. It is now a single row: the current user opens a dropdown with Profile, Notifications (with the unread count), Integrations, Sync, Feedback, About and, when available, Install App. Settings sits beside the row as a gear icon button. Signed out, the row reads "Login / New User" and its first item leads to the sign-in page. The row reuses DropdownMenu, so arrow keys, Enter and Escape work and focus returns to the trigger. An unread-notifications dot shows on the row while the menu is closed. To serve both the floating Feedback button and the menu item, the feedback dialog moved into useFeedbackDialog (FeedbackMenuItem is now FeedbackButton), and SyncMenuItem became a useSyncStatus hook. E2E specs that clicked the old panel entries go through the new openAccountMenu / clickAccountMenuItem helpers, and signIn waits for the account row instead of a link to /app/agent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81
The status icon's SVG title ("Connected", "Offline") became part of the
menu item's accessible name. Hide the icon from assistive tech; the status
is still in the item's tooltip.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81
Polleps
marked this pull request as ready for review
September 29, 2026 13:29
1 of 3 tasks
joepio
added a commit
that referenced
this pull request
Sep 30, 2026
…s where the sidebar /app/agent link was
joepio
added a commit
that referenced
this pull request
Sep 30, 2026
…ent images, onboarding recovery fixes (#1915) Lands #1889 (edit agents, skills and MCP servers in a dialog), #1890 (sidebar account menu in place of the App panel), #1891 (share dialog role select stays open), #1895 (document images from the local blob store) and #1917 (onboarding recovery, metadata request bursts, local bootstrap), tested together on Mancave.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
No issue. This comes from user feedback: the App section of the sidebar had too many entries. It now works like the account menus in Notion, Claude Code or Codex.
What changed
DropdownMenuwith Profile (the user page,⌘/Ctrl+Uhint), Notifications (unread count badge), divider, Integrations, Sync (live status icon, with the status as the tooltip), divider, Feedback (opens the feedback dialog), About, and Install App when the browser offers it.IconButtonnext to the row (title/aria-label"Settings").DropdownMenu, non-searchable. Arrow keys, Enter, Escape and Tab work. The trigger hasaria-haspopup/aria-expanded/aria-controls, and focus returns to it when the menu or the feedback dialog closes.aria-hiddeninside the menu item, so the item's accessible name is "Sync" and not "Connected Sync". The status is still in the tooltip.FeedbackMenuItem.tsxbecomesFeedbackButton.tsx. The dialog moved intouseFeedbackDialog(), which both the floatingFeedbackButtonand the menu item use. The fourfloatingcall sites are updated.SyncMenuItem.tsxbecomessyncStatus.tsx(useSyncStatus,getSyncIcon,getSyncLabel).NotificationsMenuItem.tsxand the unusedSideBarMenuItemcomponent are removed. The shared row styles stay.AppMenu.tsxbecomesAccountMenu.tsx..pocatalogs re-extracted: 5 new strings, 3 obsolete.E2E
test-utils.ts:openAccountMenu(page)andclickAccountMenuItem(page, name).signIn()used to wait for ana[href$="/app/agent"]sidebar link. It now waits for[data-testid="account-menu-trigger"][data-signed-in="true"].feedback,notifications,offline-tables,ollama-feedback(now tests hover highlight on the menu item),right-panel-lifecycle,signout-signin-data.Checks
pnpm typecheck(data-browser, e2e): passpnpm lint(data-browser, e2e; oxlint + oxfmt): pass, no new warningsvitestdata-browser: all pass exceptsrc/helpers/managed/recovery-enrollment.test.ts(Argon2 60s timeouts under load, unrelated to this change)Screenshots of the closed row, the open menu (desktop and mobile) and the feedback dialog were taken locally. They will be attached in a comment.
Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01P648McUYrscNsheXY5Ya81